Skip to content

Fix TriangleVertexArray.cpp compilation warning#427

Open
Kejoko wants to merge 1 commit intoDanielChappuis:masterfrom
Kejoko:kjk/fix_TriangleVertexArray_compile_warning
Open

Fix TriangleVertexArray.cpp compilation warning#427
Kejoko wants to merge 1 commit intoDanielChappuis:masterfrom
Kejoko:kjk/fix_TriangleVertexArray_compile_warning

Conversation

@Kejoko
Copy link

@Kejoko Kejoko commented Jul 24, 2025 •
edited
Loading

When attempting to compile with -Wreturn-type and -Werror flags we get the following error:

Building CXX object my_repo/reactphysics3d.dir/src/collision/TriangleVertexArray.cpp.o
/Users/my_name/my_repo/reactphysics3d/src/collision/TriangleVertexArray.cpp:163:1: warning: non-void function does not return a value in all control paths [-Wreturn-type]
  163 | }
      | ^

This is because the end of the TriangleVertexArray::getVertex function doesn't have a return statement outside of the else block (which realistically will never get reached, but the compiler still complains). Adding the return Vector3::zero() line fixes the issue:

Vector3 TriangleVertexArray::getVertex(uint32 vertexIndex) const {
    ...

    if (mVertexDataType == TriangleVertexArray::VertexDataType::VERTEX_FLOAT_TYPE) {
        ...
        return Vector3(decimal(vertices[0]), decimal(vertices[1]), decimal(vertices[2]));
    }
    else if (mVertexDataType == TriangleVertexArray::VertexDataType::VERTEX_DOUBLE_TYPE) {
        ...
        return Vector3(decimal(vertices[0]), decimal(vertices[1]), decimal(vertices[2]));
    }
    else {
        assert(false);
    }

    return Vector3::zero();
}

This change makes the TriangleVertexArray::getVertex function follow the same return flow as the TriangleVertexArray::getVertex function:

Vector3 TriangleVertexArray::getVertexNormal(uint32 vertexIndex) const {
    ...

    if (mVertexNormaldDataType == TriangleVertexArray::NormalDataType::NORMAL_FLOAT_TYPE) {
        ...
        return Vector3(decimal(normal[0]), decimal(normal[1]), decimal(normal[2]));
    }
    else if (mVertexNormaldDataType == TriangleVertexArray::NormalDataType::NORMAL_DOUBLE_TYPE) {
        ...
        return Vector3(decimal(normal[0]), decimal(normal[1]), decimal(normal[2]));
    }
    else {
        assert(false);
    }

    return Vector3::zero();
}

@Kejoko Kejoko changed the title Fix the compilation error Fix TriangleVertexArray.cpp compilation warning Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Kejoko